The second task and filling in on the lost days
Hello! I’ve been missing my blogs for a few days but not the work though. I am here to announce to my fans here that I completed my first task with flying colors. Although, my mentor mentioned a bunch of improvements - that I’ll list down.
There are some minor inconsistencies in the UI, functionality and some redundancies in the code, but we skip as we have spent enough time on this already. Here are a gist of things that you can keep in mind in next tasks:
- Try using the BEM convention
- Remove internal CSS and use external style.css
- Use CSS variables for colors/fonts etc.
- Remove inconsistent spacing in code (use some tool like prettier to automate this) to make it more readable
- Some repeated/overridden code in JS file and variables can be made for repetitive things
- Function/variable names (try using more meaningful ones) and casing (camelCasing is preferred in JS). Avoid using keywords as variable names.
- Try to structure your code in a better way. Keep related code together.
- You can merge the main branch with latest code and update the vercel deployment on main url
- I think now you would be having better understanding of creating fluid/responsive layouts. Additionally, I think you will better be able to estimate the next tasks.
- I hope you have learnt well from this task. How about starting with next one.
Here’s the link to the task, and this was my final version.
Then I started with my next task.
I had an issue in the beginning, I applied margin to the child element but it gave margin to the parent as well. So, Jerry came to the rescue and gave the solution that I need to make the container flex
. Here’s the deployed version of that issue.
After that I worked on the mobile view. I wanted to have something like this:
So, I try adding text for that, but it didn’t quite work out.
But Amanjot gave the solution that I should create a div for circle and an hr tag for the line. And I completed the mobile view version only. Have a look.
There’s still the issue of separator lines being too bold and ofcourse the desktop view. I will continue on it tomorrow.
Till then, signing off. Sahibee